Clang static analysis reports an 'Assigned value is garbage or undefined' error. This happens if the default_tune data has not been copied in the kTUNE case. Extending this further, it does not make sense to save the tune data if the tune was not found, or if the tune already exists.master
error("Bad tune name: '%s;", new_tune.name); | error("Bad tune name: '%s;", new_tune.name); | ||||
break; | break; | ||||
case kENDTUNE: | case kENDTUNE: | ||||
if (!found) continue; | |||||
if (done_onset == 0) { | if (done_onset == 0) { | ||||
new_tune.unstr_start[0] = new_tune.unstr_start[1]; | new_tune.unstr_start[0] = new_tune.unstr_start[1]; | ||||
new_tune.unstr_end[0] = new_tune.unstr_end[1]; | new_tune.unstr_end[0] = new_tune.unstr_end[1]; |